From b75d8dc5642b71eb029e7cd38031a32029e736cc Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Fri, 26 Jun 2020 15:13:33 +0900 Subject: treewide: convert bd_t to struct bd_info by coccinelle The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include #include void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: @@ typedef bd_t; @@ -bd_t +struct bd_info Signed-off-by: Masahiro Yamada --- board/BuR/common/bur_common.h | 2 +- board/BuR/common/common.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'board/BuR') diff --git a/board/BuR/common/bur_common.h b/board/BuR/common/bur_common.h index 618cebc1a5..c64ebe93b0 100644 --- a/board/BuR/common/bur_common.h +++ b/board/BuR/common/bur_common.h @@ -22,7 +22,7 @@ void pmicsetup(u32 mpupll, unsigned int bus); void enable_uart0_pin_mux(void); void enable_i2c_pin_mux(void); void enable_board_pin_mux(void); -int board_eth_init(bd_t *bis); +int board_eth_init(struct bd_info *bis); int brdefaultip_setup(int bus, int chip); diff --git a/board/BuR/common/common.c b/board/BuR/common/common.c index 3bc1d064ca..0a5104a48f 100644 --- a/board/BuR/common/common.c +++ b/board/BuR/common/common.c @@ -246,7 +246,7 @@ void lcd_enable(void) } #endif /* CONFIG_LCD */ -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { int nodeoffset; -- cgit