From 6c253be7ce19bec6dba386fc55f4986de65281d0 Mon Sep 17 00:00:00 2001 From: Michal Simek Date: Mon, 16 Jul 2018 13:34:55 +0200 Subject: watchdog: cdns: Add comment for expire_now function IP itself has no reg/no bit which can be used for this functionality. Add this note to the driver to make sure that none will be asking for that. Current method is to setup 1s timeout and hang() which is done via wdt_expire_now(). Signed-off-by: Michal Simek --- drivers/watchdog/cdns_wdt.c | 1 + 1 file changed, 1 insertion(+) (limited to 'drivers/watchdog/cdns_wdt.c') diff --git a/drivers/watchdog/cdns_wdt.c b/drivers/watchdog/cdns_wdt.c index f7618f86da..71575cb300 100644 --- a/drivers/watchdog/cdns_wdt.c +++ b/drivers/watchdog/cdns_wdt.c @@ -251,6 +251,7 @@ static const struct wdt_ops cdns_wdt_ops = { .start = cdns_wdt_start, .reset = cdns_wdt_reset, .stop = cdns_wdt_stop, + /* There is no bit/reg/support in IP for expire_now functionality */ }; static const struct udevice_id cdns_wdt_ids[] = { -- cgit From 0bd83060c2b01331f1b989433bc400b5bf002f9f Mon Sep 17 00:00:00 2001 From: Michal Simek Date: Tue, 17 Jul 2018 13:17:39 +0200 Subject: watchdog: cadence: Do not stop wdt in probe Watchdog can be started before probe and u-boot should just take control over it. That's why do not stop watchdog in probe to cover cases where watchdog can expire before probe and start. Signed-off-by: Michal Simek --- drivers/watchdog/cdns_wdt.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'drivers/watchdog/cdns_wdt.c') diff --git a/drivers/watchdog/cdns_wdt.c b/drivers/watchdog/cdns_wdt.c index 71575cb300..fc85fbcec2 100644 --- a/drivers/watchdog/cdns_wdt.c +++ b/drivers/watchdog/cdns_wdt.c @@ -224,8 +224,6 @@ static int cdns_wdt_probe(struct udevice *dev) { debug("%s: Probing wdt%u\n", __func__, dev->seq); - cdns_wdt_stop(dev); - return 0; } -- cgit