summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHeinrich Schuchardt <xypron.glpk@gmx.de>2020-09-26 07:50:36 +0200
committerHeinrich Schuchardt <xypron.glpk@gmx.de>2020-09-28 12:20:19 +0200
commitc48e9f310b950e39a91cea74b6708dd4fe2eb39c (patch)
tree6d32a1601de2a11a4fd3f8b2152ebd42a431171e
parentb59c13d42f42811912fd08f32f11e68a8e708c00 (diff)
riscv: restore global data pointer in trap handler
The gp register is used to store U-Boot's global data pointer. We should not assume that an UEFI application leaves the gp register unchanged as the UEFI specifications does not define who is the owner of the gp and tp registers. So the following sequence should be followed in the trap handler: * save the caller's gp register * restore the global data pointer * serve interrupts or print crash dump and reset * restore the caller's gp register Cc: Abner Chang <abner.chang@hpe.com> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Reviewed-by: Bin Meng <bin.meng@windriver.com> Reviewed-by: Rick Chen <rick@andestech.com>
-rw-r--r--arch/riscv/lib/interrupts.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/arch/riscv/lib/interrupts.c b/arch/riscv/lib/interrupts.c
index cd47e64487..8ff40f0f36 100644
--- a/arch/riscv/lib/interrupts.c
+++ b/arch/riscv/lib/interrupts.c
@@ -111,6 +111,9 @@ ulong handle_trap(ulong cause, ulong epc, ulong tval, struct pt_regs *regs)
{
ulong is_irq, irq;
+ /* An UEFI application may have changed gd. Restore U-Boot's gd. */
+ efi_restore_gd();
+
is_irq = (cause & MCAUSE_INT);
irq = (cause & ~MCAUSE_INT);