summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Glass <sjg@chromium.org>2019-04-08 13:20:49 -0600
committerSimon Glass <sjg@chromium.org>2019-04-23 20:26:43 -0600
commitf611a46ef1dc70bbbf013d0c33978d1204aeabc5 (patch)
tree96c5ea9cd354e68a390c1c31e8bab5d0dbe8c182
parentca49b2c6e2cc66d7b84e7559cadfc8bf792a2170 (diff)
div64: Don't instrument the division function
This function may be called from tracing code, since that code needs to read the timer and this often requires calling do_div(), which calls __div64_32(). If this function is instrumented it causes an infinite loop, since emitting a trace record requests the time, which in turn emits a trace record, etc. Update the prototype to prevent instrumentation code being added. Signed-off-by: Simon Glass <sjg@chromium.org>
-rw-r--r--lib/div64.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/lib/div64.c b/lib/div64.c
index 7abc68c333..62933c92c4 100644
--- a/lib/div64.c
+++ b/lib/div64.c
@@ -25,7 +25,13 @@
#if BITS_PER_LONG == 32
#ifndef __div64_32
-u32 __attribute__((weak)) __div64_32(u64 *n, u32 base)
+/*
+ * Don't instrument this function as it may be called from tracing code, since
+ * it needs to read the timer and this often requires calling do_div(), which
+ * calls this function.
+ */
+uint32_t __attribute__((weak, no_instrument_function)) __div64_32(u64 *n,
+ u32 base)
{
u64 rem = *n;
u64 b = base;