diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /arch/arm/mach-omap2/fdt-common.c | |
parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'arch/arm/mach-omap2/fdt-common.c')
-rw-r--r-- | arch/arm/mach-omap2/fdt-common.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/arch/arm/mach-omap2/fdt-common.c b/arch/arm/mach-omap2/fdt-common.c index 5f344f8283..5eb0447312 100644 --- a/arch/arm/mach-omap2/fdt-common.c +++ b/arch/arm/mach-omap2/fdt-common.c @@ -21,7 +21,7 @@ #define CONFIG_SECURE_RUNTIME_RESV_SRAM_SZ (0) #endif -int ft_hs_disable_rng(void *fdt, bd_t *bd) +int ft_hs_disable_rng(void *fdt, struct bd_info *bd) { const char *path; int offs; @@ -69,7 +69,7 @@ static int fdt_pack_reg(const void *fdt, void *buf, u64 address, u64 size) return p - (char *)buf; } -int ft_hs_fixup_dram(void *fdt, bd_t *bd) +int ft_hs_fixup_dram(void *fdt, struct bd_info *bd) { const char *path, *subpath; int offs, len; @@ -122,10 +122,10 @@ int ft_hs_fixup_dram(void *fdt, bd_t *bd) return 0; } #else -int ft_hs_fixup_dram(void *fdt, bd_t *bd) { return 0; } +int ft_hs_fixup_dram(void *fdt, struct bd_info *bd) { return 0; } #endif -int ft_hs_add_tee(void *fdt, bd_t *bd) +int ft_hs_add_tee(void *fdt, struct bd_info *bd) { const char *path, *subpath; int offs; |