diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /arch/powerpc/lib/bootm.c | |
parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'arch/powerpc/lib/bootm.c')
-rw-r--r-- | arch/powerpc/lib/bootm.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/arch/powerpc/lib/bootm.c b/arch/powerpc/lib/bootm.c index cd92db0a92..8c8ed99cd3 100644 --- a/arch/powerpc/lib/bootm.c +++ b/arch/powerpc/lib/bootm.c @@ -38,7 +38,7 @@ DECLARE_GLOBAL_DATA_PTR; static ulong get_sp (void); extern void ft_fixup_num_cores(void *blob); -static void set_clocks_in_mhz (bd_t *kbd); +static void set_clocks_in_mhz (struct bd_info *kbd); #ifndef CONFIG_SYS_LINUX_LOWMEM_MAX_SIZE #define CONFIG_SYS_LINUX_LOWMEM_MAX_SIZE (768*1024*1024) @@ -46,13 +46,13 @@ static void set_clocks_in_mhz (bd_t *kbd); static void boot_jump_linux(bootm_headers_t *images) { - void (*kernel)(bd_t *, ulong r4, ulong r5, ulong r6, - ulong r7, ulong r8, ulong r9); + void (*kernel)(struct bd_info *, ulong r4, ulong r5, ulong r6, + ulong r7, ulong r8, ulong r9); #ifdef CONFIG_OF_LIBFDT char *of_flat_tree = images->ft_addr; #endif - kernel = (void (*)(bd_t *, ulong, ulong, ulong, + kernel = (void (*)(struct bd_info *, ulong, ulong, ulong, ulong, ulong, ulong))images->ep; debug("## Transferring control to Linux (at address %08lx) ...\n", (ulong)kernel); @@ -84,7 +84,7 @@ static void boot_jump_linux(bootm_headers_t *images) */ debug(" Booting using OF flat tree...\n"); WATCHDOG_RESET (); - (*kernel) ((bd_t *)of_flat_tree, 0, 0, EPAPR_MAGIC, + (*kernel) ((struct bd_info *)of_flat_tree, 0, 0, EPAPR_MAGIC, env_get_bootm_mapsize(), 0, 0); /* does not return */ } else @@ -104,7 +104,7 @@ static void boot_jump_linux(bootm_headers_t *images) ulong cmd_end = images->cmdline_end; ulong initrd_start = images->initrd_start; ulong initrd_end = images->initrd_end; - bd_t *kbd = images->kbd; + struct bd_info *kbd = images->kbd; debug(" Booting using board info...\n"); WATCHDOG_RESET (); @@ -200,7 +200,7 @@ static int boot_bd_t_linux(bootm_headers_t *images) { ulong of_size = images->ft_len; struct lmb *lmb = &images->lmb; - bd_t **kbd = &images->kbd; + struct bd_info **kbd = &images->kbd; int ret = 0; @@ -270,7 +270,7 @@ static ulong get_sp (void) return sp; } -static void set_clocks_in_mhz (bd_t *kbd) +static void set_clocks_in_mhz (struct bd_info *kbd) { char *s; |