diff options
| author | Simon Glass <sjg@chromium.org> | 2019-02-16 20:24:45 -0700 |
|---|---|---|
| committer | Bin Meng <bmeng.cn@gmail.com> | 2019-02-20 15:25:29 +0800 |
| commit | c6d84a30fe4cbfd438cb88d76b1cbb71dda2b2f8 (patch) | |
| tree | b00e118a852fe471eb2da4fcc22e0f7bfc4350b9 /arch/sandbox | |
| parent | 7d8fe15bb80e082c7e532f26b88b58ff64ba075a (diff) | |
sandbox: Add a note about the growing state_info struct
This struct is getting larger and in some cases is being used for things
which would be better put into a driver. For example hwspinlock is not
used outside of sandbox_hwspinlock.c.
Add a note to encourage people to put things elsewhere.
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Diffstat (limited to 'arch/sandbox')
| -rw-r--r-- | arch/sandbox/include/asm/state.h | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/arch/sandbox/include/asm/state.h b/arch/sandbox/include/asm/state.h index c724827f6c..2d773d3fa6 100644 --- a/arch/sandbox/include/asm/state.h +++ b/arch/sandbox/include/asm/state.h @@ -102,6 +102,15 @@ struct sandbox_state { ulong next_tag; /* Next address tag to allocate */ struct list_head mapmem_head; /* struct sandbox_mapmem_entry */ bool hwspinlock; /* Hardware Spinlock status */ + + /* + * This struct is getting large. + * + * Consider putting test data in driver-private structs, like + * sandbox_pch.c. + * + * If you add new members, please put them above this comment. + */ }; /* Minimum space we guarantee in the state FDT when calling read/write*/ |