diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /board/compulab/cm_fx6 | |
parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'board/compulab/cm_fx6')
-rw-r--r-- | board/compulab/cm_fx6/cm_fx6.c | 4 | ||||
-rw-r--r-- | board/compulab/cm_fx6/spl.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/board/compulab/cm_fx6/cm_fx6.c b/board/compulab/cm_fx6/cm_fx6.c index 4d71bedfb9..e2712680f9 100644 --- a/board/compulab/cm_fx6/cm_fx6.c +++ b/board/compulab/cm_fx6/cm_fx6.c @@ -458,7 +458,7 @@ static int handle_mac_address(char *env_var, uint eeprom_bus) #define SB_FX6_I2C_EEPROM_BUS 0 #define NO_MAC_ADDR "No MAC address found for %s\n" -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { int err; @@ -537,7 +537,7 @@ static const struct node_info nodes[] = { { "jedec,spi-nor", MTD_DEV_TYPE_NOR, }, }; -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { u32 baseboard_rev; int nodeoffset; diff --git a/board/compulab/cm_fx6/spl.c b/board/compulab/cm_fx6/spl.c index 7d8243563a..c3c816181f 100644 --- a/board/compulab/cm_fx6/spl.c +++ b/board/compulab/cm_fx6/spl.c @@ -356,7 +356,7 @@ static struct fsl_esdhc_cfg usdhc_cfg = { .max_bus_width = 4, }; -int board_mmc_init(bd_t *bis) +int board_mmc_init(struct bd_info *bis) { cm_fx6_set_usdhc_iomux(); |