diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /board/siemens | |
parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'board/siemens')
-rw-r--r-- | board/siemens/capricorn/board.c | 2 | ||||
-rw-r--r-- | board/siemens/corvus/board.c | 2 | ||||
-rw-r--r-- | board/siemens/draco/board.c | 2 | ||||
-rw-r--r-- | board/siemens/pxm2/board.c | 2 | ||||
-rw-r--r-- | board/siemens/rut/board.c | 2 | ||||
-rw-r--r-- | board/siemens/smartweb/smartweb.c | 2 | ||||
-rw-r--r-- | board/siemens/taurus/taurus.c | 2 |
7 files changed, 7 insertions, 7 deletions
diff --git a/board/siemens/capricorn/board.c b/board/siemens/capricorn/board.c index c46e4ff736..56973a1090 100644 --- a/board/siemens/capricorn/board.c +++ b/board/siemens/capricorn/board.c @@ -293,7 +293,7 @@ int board_init(void) } #ifdef CONFIG_OF_BOARD_SETUP -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { return 0; } diff --git a/board/siemens/corvus/board.c b/board/siemens/corvus/board.c index 28a974d978..eed055aedb 100644 --- a/board/siemens/corvus/board.c +++ b/board/siemens/corvus/board.c @@ -272,7 +272,7 @@ int dram_init(void) } #ifndef CONFIG_DM_ETH -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { int rc = 0; #ifdef CONFIG_MACB diff --git a/board/siemens/draco/board.c b/board/siemens/draco/board.c index 5ac73c0ef4..b512bdbfab 100644 --- a/board/siemens/draco/board.c +++ b/board/siemens/draco/board.c @@ -326,7 +326,7 @@ static struct cpsw_platform_data cpsw_data = { #if defined(CONFIG_DRIVER_TI_CPSW) || \ (defined(CONFIG_USB_ETHER) && defined(CONFIG_USB_MUSB_GADGET)) -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { struct ctrl_dev *cdev = (struct ctrl_dev *)CTRL_DEVICE_BASE; int n = 0; diff --git a/board/siemens/pxm2/board.c b/board/siemens/pxm2/board.c index d86a913e5f..b5e9b4242c 100644 --- a/board/siemens/pxm2/board.c +++ b/board/siemens/pxm2/board.c @@ -216,7 +216,7 @@ static struct cpsw_platform_data cpsw_data = { #if defined(CONFIG_DRIVER_TI_CPSW) || \ (defined(CONFIG_USB_ETHER) && defined(CONFIG_USB_MUSB_GADGET)) -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { int n = 0; #if (defined(CONFIG_DRIVER_TI_CPSW) && !defined(CONFIG_SPL_BUILD)) || \ diff --git a/board/siemens/rut/board.c b/board/siemens/rut/board.c index 3b109e9818..e0f232d3b8 100644 --- a/board/siemens/rut/board.c +++ b/board/siemens/rut/board.c @@ -177,7 +177,7 @@ static struct cpsw_platform_data cpsw_data = { #if defined(CONFIG_DRIVER_TI_CPSW) || \ (defined(CONFIG_USB_ETHER) && defined(CONFIG_USB_MUSB_GADGET)) -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { struct ctrl_dev *cdev = (struct ctrl_dev *)CTRL_DEVICE_BASE; int n = 0; diff --git a/board/siemens/smartweb/smartweb.c b/board/siemens/smartweb/smartweb.c index 40c9c7e21d..c6bdd97083 100644 --- a/board/siemens/smartweb/smartweb.c +++ b/board/siemens/smartweb/smartweb.c @@ -183,7 +183,7 @@ int dram_init(void) #ifndef CONFIG_DM_ETH #ifdef CONFIG_MACB -int board_eth_init(bd_t *bis) +int board_eth_init(struct bd_info *bis) { return macb_eth_initialize(0, (void *)ATMEL_BASE_EMAC0, 0x00); } diff --git a/board/siemens/taurus/taurus.c b/board/siemens/taurus/taurus.c index 927ef59650..91e29f06f6 100644 --- a/board/siemens/taurus/taurus.c +++ b/board/siemens/taurus/taurus.c @@ -263,7 +263,7 @@ static void taurus_macb_hw_init(void) #endif #ifdef CONFIG_GENERIC_ATMEL_MCI -int board_mmc_init(bd_t *bd) +int board_mmc_init(struct bd_info *bd) { at91_mci_hw_init(); |