diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /board/xes | |
parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'board/xes')
-rw-r--r-- | board/xes/common/fsl_8xxx_pci.c | 2 | ||||
-rw-r--r-- | board/xes/xpedite517x/xpedite517x.c | 4 | ||||
-rw-r--r-- | board/xes/xpedite520x/xpedite520x.c | 4 | ||||
-rw-r--r-- | board/xes/xpedite537x/xpedite537x.c | 4 | ||||
-rw-r--r-- | board/xes/xpedite550x/xpedite550x.c | 4 |
5 files changed, 9 insertions, 9 deletions
diff --git a/board/xes/common/fsl_8xxx_pci.c b/board/xes/common/fsl_8xxx_pci.c index 9981d04c62..157aa32826 100644 --- a/board/xes/common/fsl_8xxx_pci.c +++ b/board/xes/common/fsl_8xxx_pci.c @@ -65,7 +65,7 @@ void pci_init_board(void) } #if defined(CONFIG_OF_BOARD_SETUP) -void ft_board_pci_setup(void *blob, bd_t *bd) +void ft_board_pci_setup(void *blob, struct bd_info *bd) { FT_FSL_PCI_SETUP; } diff --git a/board/xes/xpedite517x/xpedite517x.c b/board/xes/xpedite517x/xpedite517x.c index 4164493277..2c9499ab20 100644 --- a/board/xes/xpedite517x/xpedite517x.c +++ b/board/xes/xpedite517x/xpedite517x.c @@ -16,7 +16,7 @@ DECLARE_GLOBAL_DATA_PTR; #if defined(CONFIG_OF_BOARD_SETUP) && defined(CONFIG_PCI) -extern void ft_board_pci_setup(void *blob, bd_t *bd); +extern void ft_board_pci_setup(void *blob, struct bd_info *bd); #endif /* @@ -73,7 +73,7 @@ int dram_init(void) } #if defined(CONFIG_OF_BOARD_SETUP) -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { #ifdef CONFIG_PCI ft_board_pci_setup(blob, bd); diff --git a/board/xes/xpedite520x/xpedite520x.c b/board/xes/xpedite520x/xpedite520x.c index 5a4a36cad1..63e1e0efe5 100644 --- a/board/xes/xpedite520x/xpedite520x.c +++ b/board/xes/xpedite520x/xpedite520x.c @@ -18,7 +18,7 @@ #include <fdt_support.h> #include <pca953x.h> -extern void ft_board_pci_setup(void *blob, bd_t *bd); +extern void ft_board_pci_setup(void *blob, struct bd_info *bd); static void flash_cs_fixup(void) { @@ -70,7 +70,7 @@ int board_early_init_r(void) } #if defined(CONFIG_OF_BOARD_SETUP) -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { #ifdef CONFIG_PCI ft_board_pci_setup(blob, bd); diff --git a/board/xes/xpedite537x/xpedite537x.c b/board/xes/xpedite537x/xpedite537x.c index 4842096c24..437b57d4ff 100644 --- a/board/xes/xpedite537x/xpedite537x.c +++ b/board/xes/xpedite537x/xpedite537x.c @@ -16,7 +16,7 @@ #include <fdt_support.h> #include <pca953x.h> -extern void ft_board_pci_setup(void *blob, bd_t *bd); +extern void ft_board_pci_setup(void *blob, struct bd_info *bd); static void flash_cs_fixup(void) { @@ -70,7 +70,7 @@ int board_early_init_r(void) } #if defined(CONFIG_OF_BOARD_SETUP) -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { #ifdef CONFIG_PCI ft_board_pci_setup(blob, bd); diff --git a/board/xes/xpedite550x/xpedite550x.c b/board/xes/xpedite550x/xpedite550x.c index 6ee70d6d29..9089a0cc72 100644 --- a/board/xes/xpedite550x/xpedite550x.c +++ b/board/xes/xpedite550x/xpedite550x.c @@ -16,7 +16,7 @@ #include <fdt_support.h> #include <pca953x.h> -extern void ft_board_pci_setup(void *blob, bd_t *bd); +extern void ft_board_pci_setup(void *blob, struct bd_info *bd); static void flash_cs_fixup(void) { @@ -70,7 +70,7 @@ int board_early_init_r(void) } #if defined(CONFIG_OF_BOARD_SETUP) -int ft_board_setup(void *blob, bd_t *bd) +int ft_board_setup(void *blob, struct bd_info *bd) { #ifdef CONFIG_PCI ft_board_pci_setup(blob, bd); |