diff options
| author | Alexander Graf <agraf@suse.de> | 2019-01-31 16:06:23 +0100 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2019-02-09 07:50:58 -0500 |
| commit | 47870afab92fca6e672c03d0dea802a55e200675 (patch) | |
| tree | bf9760e98aa2cb124b7779ac936f597392eb2e24 /common/board_r.c | |
| parent | a9484aa769b0f8312abbfa5698b685e188eea78e (diff) | |
initcall: Move to inline function
The board_r init function was complaining that we are looping through
an array, calling all our tiny init stubs sequentially via indirect
function calls (which can't be speculated, so they are slow).
The solution to that is pretty easy though. All we need to do is inline
the function that loops through the functions and the compiler will
automatically convert almost all indirect calls into direct inlined code.
With this patch, the overall code size drops (by 40 bytes on riscv64)
and boot time should become measurably faster for every target.
Signed-off-by: Alexander Graf <agraf@suse.de>
Diffstat (limited to 'common/board_r.c')
| -rw-r--r-- | common/board_r.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/common/board_r.c b/common/board_r.c index 5f3d27aa9f..472987d5d5 100644 --- a/common/board_r.c +++ b/common/board_r.c @@ -633,10 +633,7 @@ static int run_main_loop(void) } /* - * Over time we hope to remove these functions with code fragments and - * stub functions, and instead call the relevant function directly. - * - * We also hope to remove most of the driver-related init and do it if/when + * We hope to remove most of the driver-related init and do it if/when * the driver is later used. * * TODO: perhaps reset the watchdog in the initcall function after each call? |