diff options
author | Peng Fan <Peng.Fan@freescale.com> | 2015-11-27 10:12:02 +0800 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2015-12-05 18:22:28 -0500 |
commit | c6bb23c819b5dcbc5c3491673f5e408c0b9c38b3 (patch) | |
tree | a5aaf2fb6a7e5824aebe2adf2f3b62025cc210c2 /common/cli_hush.c | |
parent | 63ce348d275cddf17efa1b1c1609f214847b4643 (diff) |
common: cli_hush: avoid memory leak
Need to free memory avoid memory leak, when error.
Signed-off-by: Peng Fan <Peng.Fan@freescale.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
Diffstat (limited to 'common/cli_hush.c')
-rw-r--r-- | common/cli_hush.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/common/cli_hush.c b/common/cli_hush.c index f075459911..7f69c062a7 100644 --- a/common/cli_hush.c +++ b/common/cli_hush.c @@ -2471,11 +2471,16 @@ static int done_word(o_string *dest, struct p_context *ctx) } argc = ++child->argc; child->argv = realloc(child->argv, (argc+1)*sizeof(*child->argv)); - if (child->argv == NULL) return 1; + if (child->argv == NULL) { + free(str); + return 1; + } child->argv_nonnull = realloc(child->argv_nonnull, (argc+1)*sizeof(*child->argv_nonnull)); - if (child->argv_nonnull == NULL) + if (child->argv_nonnull == NULL) { + free(str); return 1; + } child->argv[argc-1]=str; child->argv_nonnull[argc-1] = dest->nonnull; child->argv[argc]=NULL; |