diff options
| author | Jean-Jacques Hiblot <jjhiblot@ti.com> | 2019-10-22 16:39:15 +0200 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2020-01-07 11:12:47 -0500 |
| commit | 19141d698302dd7192f04f69d32826494905031e (patch) | |
| tree | 80561e342789027ad221b454b6e591b410bfdb85 /common/spl | |
| parent | 24bf44cf88e7ee04c4bb962ede3c0e6462339c5e (diff) | |
spl: fit: be more verbose when an error occurs when applying the overlays
There are many ways the overlay application can fail.
2 of them are probably the most common:
- the application itself failed. Usually this is comes from an unresolved
reference
- DTBO not available in FIT (could be because of a typo)
In both case it is good to be more explicit about the error and at least
show which overlay is failing.
Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'common/spl')
| -rw-r--r-- | common/spl/spl_fit.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c index 0245dcadb4..5aeb9528fe 100644 --- a/common/spl/spl_fit.c +++ b/common/spl/spl_fit.c @@ -113,7 +113,7 @@ static int spl_fit_get_image_node(const void *fit, int images, node = fdt_subnode_offset(fit, images, str); if (node < 0) { - debug("cannot find image node '%s': %d\n", str, node); + pr_err("cannot find image node '%s': %d\n", str, node); return -EINVAL; } @@ -359,8 +359,11 @@ static int spl_fit_append_fdt(struct spl_image_info *spl_image, ret = fdt_overlay_apply_verbose(spl_image->fdt_addr, (void *)image_info.load_addr); - if (ret) + if (ret) { + pr_err("failed to apply DT overlay %s\n", + fit_get_name(fit, node, NULL)); break; + } debug("%s: DT overlay %s applied\n", __func__, fit_get_name(fit, node, NULL)); |