diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /drivers/ddr | |
parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'drivers/ddr')
-rw-r--r-- | drivers/ddr/altera/sdram_agilex.c | 2 | ||||
-rw-r--r-- | drivers/ddr/altera/sdram_s10.c | 2 | ||||
-rw-r--r-- | drivers/ddr/altera/sdram_soc64.c | 4 | ||||
-rw-r--r-- | drivers/ddr/altera/sdram_soc64.h | 4 |
4 files changed, 6 insertions, 6 deletions
diff --git a/drivers/ddr/altera/sdram_agilex.c b/drivers/ddr/altera/sdram_agilex.c index a0f25d1179..d6e7a175d0 100644 --- a/drivers/ddr/altera/sdram_agilex.c +++ b/drivers/ddr/altera/sdram_agilex.c @@ -30,7 +30,7 @@ int sdram_mmr_init_full(struct udevice *dev) u32 i; int ret; phys_size_t hw_size; - bd_t bd = {0}; + struct bd_info bd = {0}; /* Ensure HMC clock is running */ if (poll_hmc_clock_status()) { diff --git a/drivers/ddr/altera/sdram_s10.c b/drivers/ddr/altera/sdram_s10.c index 91f76e03c2..2945f1e1df 100644 --- a/drivers/ddr/altera/sdram_s10.c +++ b/drivers/ddr/altera/sdram_s10.c @@ -76,7 +76,7 @@ int sdram_mmr_init_full(struct udevice *dev) u32 i; int ret; phys_size_t hw_size; - bd_t bd = {0}; + struct bd_info bd = {0}; /* Enable access to DDR from CPU master */ clrbits_le32(CCU_REG_ADDR(CCU_CPU0_MPRT_ADBASE_DDRREG), diff --git a/drivers/ddr/altera/sdram_soc64.c b/drivers/ddr/altera/sdram_soc64.c index 491f689c44..8cb75fe02a 100644 --- a/drivers/ddr/altera/sdram_soc64.c +++ b/drivers/ddr/altera/sdram_soc64.c @@ -132,7 +132,7 @@ void sdram_clear_mem(phys_addr_t addr, phys_size_t size) } } -void sdram_init_ecc_bits(bd_t *bd) +void sdram_init_ecc_bits(struct bd_info *bd) { phys_size_t size, size_init; phys_addr_t start_addr; @@ -176,7 +176,7 @@ void sdram_init_ecc_bits(bd_t *bd) (unsigned int)get_timer(start)); } -void sdram_size_check(bd_t *bd) +void sdram_size_check(struct bd_info *bd) { phys_size_t total_ram_check = 0; phys_size_t ram_check = 0; diff --git a/drivers/ddr/altera/sdram_soc64.h b/drivers/ddr/altera/sdram_soc64.h index 7b25a80ae2..4a830e7ec1 100644 --- a/drivers/ddr/altera/sdram_soc64.h +++ b/drivers/ddr/altera/sdram_soc64.h @@ -179,8 +179,8 @@ int emif_clear(struct altera_sdram_platdata *plat); int emif_reset(struct altera_sdram_platdata *plat); int poll_hmc_clock_status(void); void sdram_clear_mem(phys_addr_t addr, phys_size_t size); -void sdram_init_ecc_bits(bd_t *bd); -void sdram_size_check(bd_t *bd); +void sdram_init_ecc_bits(struct bd_info *bd); +void sdram_size_check(struct bd_info *bd); phys_size_t sdram_calculate_size(struct altera_sdram_platdata *plat); int sdram_mmr_init_full(struct udevice *dev); |