diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /drivers/net/fm | |
parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'drivers/net/fm')
-rw-r--r-- | drivers/net/fm/eth.c | 2 | ||||
-rw-r--r-- | drivers/net/fm/init.c | 2 | ||||
-rw-r--r-- | drivers/net/fm/memac_phy.c | 2 | ||||
-rw-r--r-- | drivers/net/fm/tgec_phy.c | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/fm/eth.c b/drivers/net/fm/eth.c index 62396d3a16..2f433cedd0 100644 --- a/drivers/net/fm/eth.c +++ b/drivers/net/fm/eth.c @@ -464,7 +464,7 @@ static void fmc_tx_port_graceful_stop_disable(struct fm_eth *fm_eth) } #ifndef CONFIG_DM_ETH -static int fm_eth_open(struct eth_device *dev, bd_t *bd) +static int fm_eth_open(struct eth_device *dev, struct bd_info *bd) #else static int fm_eth_open(struct udevice *dev) #endif diff --git a/drivers/net/fm/init.c b/drivers/net/fm/init.c index 2cc8bbfb10..2fed64205c 100644 --- a/drivers/net/fm/init.c +++ b/drivers/net/fm/init.c @@ -87,7 +87,7 @@ struct fm_eth_info fm_info[] = { #endif }; -int fm_standard_init(bd_t *bis) +int fm_standard_init(struct bd_info *bis) { int i; struct ccsr_fman *reg; diff --git a/drivers/net/fm/memac_phy.c b/drivers/net/fm/memac_phy.c index 4cbfbc70ab..e15c28d500 100644 --- a/drivers/net/fm/memac_phy.c +++ b/drivers/net/fm/memac_phy.c @@ -166,7 +166,7 @@ int memac_mdio_reset(struct mii_dev *bus) } #ifndef CONFIG_DM_ETH -int fm_memac_mdio_init(bd_t *bis, struct memac_mdio_info *info) +int fm_memac_mdio_init(struct bd_info *bis, struct memac_mdio_info *info) { struct mii_dev *bus = mdio_alloc(); diff --git a/drivers/net/fm/tgec_phy.c b/drivers/net/fm/tgec_phy.c index f6c98f2e29..22225c2f82 100644 --- a/drivers/net/fm/tgec_phy.c +++ b/drivers/net/fm/tgec_phy.c @@ -105,7 +105,7 @@ static int tgec_mdio_reset(struct mii_dev *bus) return 0; } -int fm_tgec_mdio_init(bd_t *bis, struct tgec_mdio_info *info) +int fm_tgec_mdio_init(struct bd_info *bis, struct tgec_mdio_info *info) { struct mii_dev *bus = mdio_alloc(); |