diff options
| author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
| commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
| tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /drivers/net/natsemi.c | |
| parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'drivers/net/natsemi.c')
| -rw-r--r-- | drivers/net/natsemi.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c index bf6fa8f2ba..bfd8cc396b 100644 --- a/drivers/net/natsemi.c +++ b/drivers/net/natsemi.c @@ -230,7 +230,7 @@ static void write_eeprom(struct eth_device *dev, long addr, int location, #endif static int read_eeprom(struct eth_device *dev, long addr, int location); static int mdio_read(struct eth_device *dev, int phy_id, int location); -static int natsemi_init(struct eth_device *dev, bd_t * bis); +static int natsemi_init(struct eth_device *dev, struct bd_info * bis); static void natsemi_reset(struct eth_device *dev); static void natsemi_init_rxfilter(struct eth_device *dev); static void natsemi_init_txd(struct eth_device *dev); @@ -287,7 +287,7 @@ OUTL(struct eth_device *dev, int command, u_long addr) */ int -natsemi_initialize(bd_t * bis) +natsemi_initialize(struct bd_info * bis) { pci_dev_t devno; int card_number = 0; @@ -556,7 +556,7 @@ mdio_read(struct eth_device *dev, int phy_id, int location) */ static int -natsemi_init(struct eth_device *dev, bd_t * bis) +natsemi_init(struct eth_device *dev, struct bd_info * bis) { natsemi_reset(dev); |