diff options
| author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
| commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
| tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /drivers/net/tsec.c | |
| parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'drivers/net/tsec.c')
| -rw-r--r-- | drivers/net/tsec.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c index 3d75acb6b4..5d12e4b775 100644 --- a/drivers/net/tsec.c +++ b/drivers/net/tsec.c @@ -554,7 +554,7 @@ static void startup_tsec(struct tsec_private *priv) * This allows U-Boot to find the first active controller. */ #ifndef CONFIG_DM_ETH -static int tsec_init(struct eth_device *dev, bd_t *bd) +static int tsec_init(struct eth_device *dev, struct bd_info *bd) #else static int tsec_init(struct udevice *dev) #endif @@ -701,7 +701,8 @@ static int init_phy(struct tsec_private *priv) * Initialize device structure. Returns success if PHY * initialization succeeded (i.e. if it recognizes the PHY) */ -static int tsec_initialize(bd_t *bis, struct tsec_info_struct *tsec_info) +static int tsec_initialize(struct bd_info *bis, + struct tsec_info_struct *tsec_info) { struct tsec_private *priv; struct eth_device *dev; @@ -760,7 +761,8 @@ static int tsec_initialize(bd_t *bis, struct tsec_info_struct *tsec_info) * * Returns the number of TSEC devices that were initialized */ -int tsec_eth_init(bd_t *bis, struct tsec_info_struct *tsecs, int num) +int tsec_eth_init(struct bd_info *bis, struct tsec_info_struct *tsecs, + int num) { int i; int count = 0; @@ -775,7 +777,7 @@ int tsec_eth_init(bd_t *bis, struct tsec_info_struct *tsecs, int num) return count; } -int tsec_standard_init(bd_t *bis) +int tsec_standard_init(struct bd_info *bis) { struct fsl_pq_mdio_info info; |