diff options
| author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
| commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
| tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /drivers/qe | |
| parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) | |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'drivers/qe')
| -rw-r--r-- | drivers/qe/uec.c | 8 | ||||
| -rw-r--r-- | drivers/qe/uec.h | 6 |
2 files changed, 7 insertions, 7 deletions
diff --git a/drivers/qe/uec.c b/drivers/qe/uec.c index 849f191d6d..0143454387 100644 --- a/drivers/qe/uec.c +++ b/drivers/qe/uec.c @@ -1189,7 +1189,7 @@ static int uec_startup(uec_private_t *uec) return 0; } -static int uec_init(struct eth_device* dev, bd_t *bd) +static int uec_init(struct eth_device* dev, struct bd_info *bd) { uec_private_t *uec; int err, i; @@ -1349,7 +1349,7 @@ static int uec_recv(struct eth_device* dev) return 1; } -int uec_initialize(bd_t *bis, uec_info_t *uec_info) +int uec_initialize(struct bd_info *bis, uec_info_t *uec_info) { struct eth_device *dev; int i; @@ -1416,7 +1416,7 @@ int uec_initialize(bd_t *bis, uec_info_t *uec_info) return 1; } -int uec_eth_init(bd_t *bis, uec_info_t *uecs, int num) +int uec_eth_init(struct bd_info *bis, uec_info_t *uecs, int num) { int i; @@ -1426,7 +1426,7 @@ int uec_eth_init(bd_t *bis, uec_info_t *uecs, int num) return 0; } -int uec_standard_init(bd_t *bis) +int uec_standard_init(struct bd_info *bis) { return uec_eth_init(bis, uec_info, ARRAY_SIZE(uec_info)); } diff --git a/drivers/qe/uec.h b/drivers/qe/uec.h index 5f8baefb10..6de2ac44f8 100644 --- a/drivers/qe/uec.h +++ b/drivers/qe/uec.h @@ -735,7 +735,7 @@ typedef struct uec_private { int oldlink; } uec_private_t; -int uec_initialize(bd_t *bis, uec_info_t *uec_info); -int uec_eth_init(bd_t *bis, uec_info_t *uecs, int num); -int uec_standard_init(bd_t *bis); +int uec_initialize(struct bd_info *bis, uec_info_t *uec_info); +int uec_eth_init(struct bd_info *bis, uec_info_t *uecs, int num); +int uec_standard_init(struct bd_info *bis); #endif /* __UEC_H__ */ |