diff options
author | Masahiro Yamada <masahiroy@kernel.org> | 2020-06-26 15:13:33 +0900 |
---|---|---|
committer | Tom Rini <trini@konsulko.com> | 2020-07-17 09:30:13 -0400 |
commit | b75d8dc5642b71eb029e7cd38031a32029e736cc (patch) | |
tree | e13a2c309a27c528a79f7c49b468c0c2d246a499 /drivers/usb | |
parent | 02ff91e8c60f1f48bee8f4bd1c87ea0892cc5dae (diff) |
treewide: convert bd_t to struct bd_info by coccinelle
The Linux coding style guide (Documentation/process/coding-style.rst)
clearly says:
It's a **mistake** to use typedef for structures and pointers.
Besides, using typedef for structures is annoying when you try to make
headers self-contained.
Let's say you have the following function declaration in a header:
void foo(bd_t *bd);
This is not self-contained since bd_t is not defined.
To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h>
#include <asm/u-boot.h>
void foo(bd_t *bd);
Then, the include direcective pulls in more bloat needlessly.
If you use 'struct bd_info' instead, it is enough to put a forward
declaration as follows:
struct bd_info;
void foo(struct bd_info *bd);
Right, typedef'ing bd_t is a mistake.
I used coccinelle to generate this commit.
The semantic patch that makes this change is as follows:
<smpl>
@@
typedef bd_t;
@@
-bd_t
+struct bd_info
</smpl>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'drivers/usb')
-rw-r--r-- | drivers/usb/common/fsl-dt-fixup.c | 2 | ||||
-rw-r--r-- | drivers/usb/eth/asix.c | 2 | ||||
-rw-r--r-- | drivers/usb/eth/asix88179.c | 2 | ||||
-rw-r--r-- | drivers/usb/eth/mcs7830.c | 2 | ||||
-rw-r--r-- | drivers/usb/eth/r8152.c | 2 | ||||
-rw-r--r-- | drivers/usb/eth/smsc95xx.c | 2 | ||||
-rw-r--r-- | drivers/usb/gadget/ether.c | 4 |
7 files changed, 8 insertions, 8 deletions
diff --git a/drivers/usb/common/fsl-dt-fixup.c b/drivers/usb/common/fsl-dt-fixup.c index 0759ec774a..4d7a2acd8e 100644 --- a/drivers/usb/common/fsl-dt-fixup.c +++ b/drivers/usb/common/fsl-dt-fixup.c @@ -132,7 +132,7 @@ static int fsl_fdt_fixup_erratum(int *usb_erratum_off, void *blob, return 0; } -void fsl_fdt_fixup_dr_usb(void *blob, bd_t *bd) +void fsl_fdt_fixup_dr_usb(void *blob, struct bd_info *bd) { static const char * const modes[] = { "host", "peripheral", "otg" }; static const char * const phys[] = { "ulpi", "utmi", "utmi_dual" }; diff --git a/drivers/usb/eth/asix.c b/drivers/usb/eth/asix.c index db75ae2498..ac4a27fff2 100644 --- a/drivers/usb/eth/asix.c +++ b/drivers/usb/eth/asix.c @@ -498,7 +498,7 @@ static int asix_send_common(struct ueth_data *dev, void *packet, int length) /* * Asix callbacks */ -static int asix_init(struct eth_device *eth, bd_t *bd) +static int asix_init(struct eth_device *eth, struct bd_info *bd) { struct ueth_data *dev = (struct ueth_data *)eth->priv; diff --git a/drivers/usb/eth/asix88179.c b/drivers/usb/eth/asix88179.c index 381bef2bed..c142b8b19b 100644 --- a/drivers/usb/eth/asix88179.c +++ b/drivers/usb/eth/asix88179.c @@ -509,7 +509,7 @@ static int asix_send_common(struct ueth_data *dev, /* * Asix callbacks */ -static int asix_init(struct eth_device *eth, bd_t *bd) +static int asix_init(struct eth_device *eth, struct bd_info *bd) { struct ueth_data *dev = (struct ueth_data *)eth->priv; struct asix_private *dev_priv = (struct asix_private *)dev->dev_priv; diff --git a/drivers/usb/eth/mcs7830.c b/drivers/usb/eth/mcs7830.c index 0cb7dbc8fb..c829a436a3 100644 --- a/drivers/usb/eth/mcs7830.c +++ b/drivers/usb/eth/mcs7830.c @@ -586,7 +586,7 @@ static int mcs7830_recv_common(struct ueth_data *ueth, uint8_t *buf) * ensures that the link is up and subsequent send() and recv() calls can * exchange ethernet frames */ -static int mcs7830_init(struct eth_device *eth, bd_t *bd) +static int mcs7830_init(struct eth_device *eth, struct bd_info *bd) { struct ueth_data *dev = eth->priv; diff --git a/drivers/usb/eth/r8152.c b/drivers/usb/eth/r8152.c index f201a1789b..1845d957f9 100644 --- a/drivers/usb/eth/r8152.c +++ b/drivers/usb/eth/r8152.c @@ -1249,7 +1249,7 @@ static int r8152_send_common(struct ueth_data *ueth, void *packet, int length) } #ifndef CONFIG_DM_ETH -static int r8152_init(struct eth_device *eth, bd_t *bd) +static int r8152_init(struct eth_device *eth, struct bd_info *bd) { struct ueth_data *dev = (struct ueth_data *)eth->priv; struct r8152 *tp = (struct r8152 *)dev->dev_priv; diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c index d3532df141..b293a808a3 100644 --- a/drivers/usb/eth/smsc95xx.c +++ b/drivers/usb/eth/smsc95xx.c @@ -716,7 +716,7 @@ static int smsc95xx_send_common(struct ueth_data *dev, void *packet, int length) /* * Smsc95xx callbacks */ -static int smsc95xx_init(struct eth_device *eth, bd_t *bd) +static int smsc95xx_init(struct eth_device *eth, struct bd_info *bd) { struct ueth_data *dev = (struct ueth_data *)eth->priv; struct usb_device *udev = dev->pusb_dev; diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c index 6f04523f15..a939918e97 100644 --- a/drivers/usb/gadget/ether.c +++ b/drivers/usb/gadget/ether.c @@ -2523,7 +2523,7 @@ static void _usb_eth_halt(struct ether_priv *priv) } #ifndef CONFIG_DM_ETH -static int usb_eth_init(struct eth_device *netdev, bd_t *bd) +static int usb_eth_init(struct eth_device *netdev, struct bd_info *bd) { struct ether_priv *priv = (struct ether_priv *)netdev->priv; @@ -2571,7 +2571,7 @@ void usb_eth_halt(struct eth_device *netdev) _usb_eth_halt(priv); } -int usb_eth_initialize(bd_t *bi) +int usb_eth_initialize(struct bd_info *bi) { struct eth_device *netdev = &l_priv->netdev; |