summaryrefslogtreecommitdiff
path: root/env/common.c
diff options
context:
space:
mode:
authorSimon Glass <sjg@chromium.org>2017-08-03 12:21:53 -0600
committerTom Rini <trini@konsulko.com>2017-08-15 08:18:46 -0400
commit5fc5254084ea367a383a968cc4f79d003cccebd2 (patch)
tree77585503beec80c8b8ccaced34daee9bea11246f /env/common.c
parent0219fb61c1378152b11f0e21e1e4db89081f15da (diff)
env: common: Factor out the common env_valid check
The check for gd->env_valid is used in both the 'if' and 'else' part of env_get_char(). Move it into that function instead for simplicity. Drop that code from the two leaf functions. Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-by: Tom Rini <trini@konsulko.com>
Diffstat (limited to 'env/common.c')
-rw-r--r--env/common.c17
1 files changed, 6 insertions, 11 deletions
diff --git a/env/common.c b/env/common.c
index 2e94dd71e2..bfa8cfb143 100644
--- a/env/common.c
+++ b/env/common.c
@@ -34,25 +34,20 @@ __weak uchar env_get_char_spec(int index)
static uchar env_get_char_init(int index)
{
- /* if crc was bad, use the default environment */
- if (gd->env_valid)
- return env_get_char_spec(index);
- else
- return default_environment[index];
+ return env_get_char_spec(index);
}
static uchar env_get_char_memory(int index)
{
- if (gd->env_valid)
- return *(uchar *)(gd->env_addr + index);
- else
- return default_environment[index];
+ return *(uchar *)(gd->env_addr + index);
}
uchar env_get_char(int index)
{
- /* if relocated to RAM */
- if (gd->flags & GD_FLG_RELOC)
+ /* if env is not set up, or crc was bad, use the default environment */
+ if (!gd->env_valid)
+ return default_environment[index];
+ else if (gd->flags & GD_FLG_RELOC) /* if relocated to RAM */
return env_get_char_memory(index);
else
return env_get_char_init(index);