summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorHeiko Stuebner <heiko@sntech.de>2018-09-21 10:59:48 +0200
committerPhilipp Tomsich <philipp.tomsich@theobroma-systems.com>2018-10-02 09:35:39 +0200
commite4d5fa3db0b9ad6551752f90b153d64706bbddef (patch)
tree5d975e89c0271123712afb4b3c249f744c2db90d /include
parent598a26a8fb94b7b86ecd2f4762eb5fcf46b9664e (diff)
rockchip: rk3188: explicitly set vcc_sd0 pin to gpio on rk3188-radxarock
It is good practice to make the setting of gpio-pinctrls explicitly in the devicetree, and in this case even necessary. Rockchip boards start with iomux settings set to gpio for most pins and while the linux pinctrl driver also implicitly sets the gpio function if a pin is requested as gpio that is not necessarily true for other drivers. The issue in question stems from uboot, where the sdmmc_pwr pin is set to function 1 (sdmmc-power) by the bootrom when reading the 1st-stage loader. The regulator controlled by the pin is active-low though, so when the dwmmc hw-block sets its enabled bit, it actually disables the regulator. By changing the pin back to gpio we fix that behaviour. [picked from the identical linux patch https://patchwork.kernel.org/patch/10609253/] Signed-off-by: Heiko Stuebner <heiko@sntech.de> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions