summaryrefslogtreecommitdiff
path: root/test/py/tests/test_dfu.py
diff options
context:
space:
mode:
authorLukasz Majewski <l.majewski@samsung.com>2016-04-20 10:36:32 +0200
committerMarek Vasut <marex@denx.de>2016-04-25 17:56:29 +0200
commitc6eb899c4d0f8311f8a9d6c991344a27b8f9d4db (patch)
tree056f5a5496c270fc835145ad6f462f571cd30f31 /test/py/tests/test_dfu.py
parent65341967ce9ef2656c61dcd3126536e8865c349d (diff)
tests: py: dfu: Add variables to store dfu alt numbers for test and dummy files
This patch replaces hardcoded (i.e. 0 and 1) values passed to dfu_{read|write} with variables. Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> Acked-by: Stephen Warren <swarren@nvidia.com> --- Changes for v3: - Replace per module global variables with ones defined inside a function Changes for v2: - None
Diffstat (limited to 'test/py/tests/test_dfu.py')
-rw-r--r--test/py/tests/test_dfu.py12
1 files changed, 8 insertions, 4 deletions
diff --git a/test/py/tests/test_dfu.py b/test/py/tests/test_dfu.py
index 093e8d0678..2e6cd7b5b3 100644
--- a/test/py/tests/test_dfu.py
+++ b/test/py/tests/test_dfu.py
@@ -99,6 +99,10 @@ def test_dfu(u_boot_console, env__usb_dev_port, env__dfu_config):
Nothing.
"""
+ # Default alt settings for test and dummy files
+ alt_setting_test_file = 0
+ alt_setting_dummy_file = 1
+
def start_dfu():
"""Start U-Boot's dfu shell command.
@@ -229,15 +233,15 @@ def test_dfu(u_boot_console, env__usb_dev_port, env__dfu_config):
u_boot_console.log.action('Writing test data to DFU primary ' +
'altsetting')
- dfu_write(0, test_f.abs_fn)
+ dfu_write(alt_setting_test_file, test_f.abs_fn)
u_boot_console.log.action('Writing dummy data to DFU secondary ' +
'altsetting to clear DFU buffers')
- dfu_write(1, dummy_f.abs_fn)
+ dfu_write(alt_setting_dummy_file, dummy_f.abs_fn)
u_boot_console.log.action('Reading DFU primary altsetting for ' +
'comparison')
- dfu_read(0, readback_fn)
+ dfu_read(alt_setting_test_file, readback_fn)
u_boot_console.log.action('Comparing written and read data')
written_hash = test_f.content_hash
@@ -266,7 +270,7 @@ def test_dfu(u_boot_console, env__usb_dev_port, env__dfu_config):
u_boot_console.log.action(
'Overwriting DFU primary altsetting with dummy data')
- dfu_write(0, dummy_f.abs_fn)
+ dfu_write(alt_setting_test_file, dummy_f.abs_fn)
for size in sizes:
with u_boot_console.log.section('Data size %d' % size):