diff options
| author | Philippe Reynes <philippe.reynes@softathome.com> | 2020-01-09 17:34:02 +0100 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2020-01-10 14:18:26 -0500 |
| commit | 3f05f087c37ec6b408dfd3b0a864c59749b5b8e1 (patch) | |
| tree | 83dce226b2519be2923f7dccc9ea9820512f651f /test | |
| parent | 53dc8ae66c5ca8dac65bd6f51c0cbb8b0d22aa2a (diff) | |
test/cmd_ut.c: fix cmd_ut_category
In the function cmd_ut_category, the prefix is used with
the function strncmp to know if the prefix should be
removed from the test name, even if the prefix is NULL.
To avoid this issue, we consider that a prefix NULL
mean no prefix. So we only try to remove the prefix
from the test_name if the prefix is not NULL, then
we avoid to call the function strncmp with a NULL
prefix.
Reported-by: Coverity CID 281110
Fixes: 4ad4edfe ("cmd_ut: add a parameter prefix to the function cmd_ut_category")
Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
Diffstat (limited to 'test')
| -rw-r--r-- | test/cmd_ut.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/cmd_ut.c b/test/cmd_ut.c index 400719e7b6..a3a9d49f7e 100644 --- a/test/cmd_ut.c +++ b/test/cmd_ut.c @@ -26,7 +26,7 @@ int cmd_ut_category(const char *name, const char *prefix, const char *test_name = test->name; /* Remove the prefix */ - if (!strncmp(test_name, prefix, prefix_len)) + if (prefix && !strncmp(test_name, prefix, prefix_len)) test_name += prefix_len; if (argc > 1 && strcmp(argv[1], test_name)) |